Widen frequenz-client-base dependency to allow v0.9.0
#116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
llucax
reviewed
Feb 20, 2025
There was a problem hiding this comment.
If this is done for compatibility reasons, you don ´t need to bump any minimum dependencies here, just widen the range for frequenz-client-base, as no code changes are needed to work with the newer version, we are still compatible with the old version(s).
You don't need to bump the channels version at all, if any other dependency require the new version, the dependency will be resolved to 1.6.1 automatically, as this repo is still compatible with any 1.x.x version.
Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
shsms
force-pushed
the
upgrade-base-client
branch
from
e3c5b7f to
6ad9ea7
Compare
shsms
changed the title
frequenz-client-base dependency to allow v0.9.0
llucax
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires that the channels version is at least v1.6.1.